Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] [full-ci] Adds cli test for cleaning the orphaned remote storage #39436

Merged
merged 1 commit into from
Oct 29, 2021
Merged

[tests-only] [full-ci] Adds cli test for cleaning the orphaned remote storage #39436

merged 1 commit into from
Oct 29, 2021

Conversation

sakshamgurung
Copy link
Contributor

@sakshamgurung sakshamgurung commented Oct 29, 2021 •
edited
Loading

Description

Adds cli test that checks if the occ sharing command cleans the orphaned remote storage or not.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@sakshamgurung sakshamgurung self-assigned this Oct 29, 2021
@sakshamgurung sakshamgurung force-pushed the occ-sharing-commands branch 3 times, most recently from 4521f6d to d83e0dc Compare October 29, 2021 07:50
@sakshamgurung sakshamgurung marked this pull request as ready for review October 29, 2021 08:00
@sonarcloud
Copy link

sonarcloud bot commented Oct 29, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit e9b88b6 into master Oct 29, 2021
@delete-merged-branch delete-merged-branch bot deleted the occ-sharing-commands branch October 29, 2021 12:59
@sakshamgurung sakshamgurung mentioned this pull request Nov 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiranparajuli589 kiranparajuli589 kiranparajuli589 left review comments

@saw-jan saw-jan saw-jan left review comments

@phil-davis phil-davis phil-davis approved these changes

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

Assignees

@sakshamgurung sakshamgurung

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

create acceptance tests for occ sharing commands
4 participants
@sakshamgurung @phil-davis @kiranparajuli589 @saw-jan